-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ArgumentError when starting persistent HTTP client
We don't really need to start its connection. Closes #7158
- Loading branch information
Showing
2 changed files
with
10 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b069e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @p0deje so i wonder if these commit has been released with specific 'selenium-webdriver' version ? I have tried with the latest of 3.142 , which is 3.142.3 but seems like the fix hasn't been there. Should i wait for another minor version or is it included in v4.0.0 alpha versions ? Thanks.
6b069e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It hasn't been released yet and will go into 4.0.0.alpha3. We can probably backport to 3.x branch too if there is a need for that. Please, let me know.
6b069e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanna prepare our test tools in terms of Selenium 4.0 era so just wanna update our code using this gem from v3.6.0 till v3.142.3 to see if any updates should have been made before migrating it to v4.0. I think it's good to have a release for this for 3.x if you don't mind. Thanks a lot.
6b069e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you’re not actually specifying to use the Persistent client class this will have no effect