-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make Driver Services consistent (#11973)
* [java] deprecate the old driver service constructors that hard coded the timeout value Users should be using the builder * [java] make javadoc and formatting consistent across driver services * [java] deprecate unused and redundant geckodriver service methods * [java] add support for safaridriver logging with service class * [java] implement additional geckodriver service features Allow log level to be set in service class, not just in options class Allow Toggling truncation of log lines Allow users to specify a different location for profile creation * [java] implement driver service logging with sendOutputTo for all drivers This allows completely silencing all logging output or directing everything from the process to a specified file * [java] process system properties at run time not compile time * [java] fix formatting * Addressing PR comments and making it compile * [Java] Conserving behaviour for setting log level --------- Co-authored-by: Diego Molina <[email protected]> Co-authored-by: Diego Molina <[email protected]>
- Loading branch information
1 parent
d530584
commit 66e51be
Showing
10 changed files
with
646 additions
and
304 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.