Skip to content

Commit

Permalink
[java] There are no more multiple IE driver engines
Browse files Browse the repository at this point in the history
  • Loading branch information
barancev committed May 8, 2018
1 parent ca9da6e commit 6359b2f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@

package org.openqa.selenium.ie;

/**
* @deprecated There are no more multiple IE driver engines
*/
@Deprecated
public enum InternetExplorerDriverEngine {
LEGACY,
AUTODETECT,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ public class InternetExplorerDriverService extends DriverService {

/**
* System property that defines the implementation of the driver engine to use.
*
* @deprecated There are no more multiple IE driver engines
*/
@Deprecated
public static final String IE_DRIVER_ENGINE_PROPERTY = "webdriver.ie.driver.engine";

/**
Expand Down Expand Up @@ -102,7 +105,6 @@ public static class Builder extends DriverService.Builder<
InternetExplorerDriverService, InternetExplorerDriverService.Builder> {

private InternetExplorerDriverLogLevel logLevel;
private InternetExplorerDriverEngine engineImplementation;
private String host = null;
private File extractPath = null;
private Boolean silent = null;
Expand All @@ -123,9 +125,11 @@ public Builder withLogLevel(InternetExplorerDriverLogLevel logLevel) {
*
* @param engineImplementation The engine implementation to be used.
* @return A self reference.
*
* @deprecated There are no more multiple IE driver engines
*/
@Deprecated
public Builder withEngineImplementation(InternetExplorerDriverEngine engineImplementation) {
this.engineImplementation = engineImplementation;
return this;
}

Expand Down Expand Up @@ -183,12 +187,6 @@ protected ImmutableList<String> createArgs() {
logLevel = InternetExplorerDriverLogLevel.valueOf(level);
}
}
if (engineImplementation == null) {
String engineToUse = System.getProperty(IE_DRIVER_ENGINE_PROPERTY);
if (engineToUse != null) {
engineImplementation = InternetExplorerDriverEngine.valueOf(engineToUse);
}
}
if (host == null) {
String hostProperty = System.getProperty(IE_DRIVER_HOST_PROPERTY);
if (hostProperty != null) {
Expand Down Expand Up @@ -216,9 +214,6 @@ protected ImmutableList<String> createArgs() {
if (logLevel != null) {
argsBuilder.add(String.format("--log-level=%s", logLevel.toString()));
}
if (engineImplementation != null) {
argsBuilder.add(String.format("--implementation=%s", engineImplementation.toString()));
}
if (host != null) {
argsBuilder.add(String.format("--host=%s", host));
}
Expand Down

0 comments on commit 6359b2f

Please sign in to comment.