Fix incorrectly used named parameters in string formatting in .NET

.NET Core does not support named parameters in string.Format(...), so this commit fixes that. Additionally, this fixes a logic error in DriverOptions. Signed-off-by: Jim Evans <[email protected]>
SeleniumHQ · Jan 10, 2020 · 5d02494 · 5d02494
1 parent 52b8149
commit 5d02494
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/dotnet/src/webdriver/DevTools/AutoGenerated/DevToolsSession.cs b/dotnet/src/webdriver/DevTools/AutoGenerated/DevToolsSession.cs
@@ -12,7 +12,7 @@ namespace OpenQA.Selenium.DevTools
     using Newtonsoft.Json.Linq;
 
     /// <summary>
-    /// Represents a WebSocket connection to a running DevTools instance that can be used to send 
+    /// Represents a WebSocket connection to a running DevTools instance that can be used to send
     /// commands and recieve events.
     ///</summary>
     public partial class DevToolsSession : IDisposable
@@ -148,8 +148,8 @@ public string EndpointAddress
 
             await OpenSessionConnection(cancellationToken);
 
-            LogTrace("Sending {id} {method}: {params}", message.CommandId, message.CommandName, @params.ToString());
-            
+            LogTrace("Sending {0} {1}: {2}", message.CommandId, message.CommandName, @params.ToString());
+
             var contents = JsonConvert.SerializeObject(message);
             var contentBuffer = Encoding.UTF8.GetBytes(contents);
 
@@ -172,7 +172,7 @@ public string EndpointAddress
                 if (!String.IsNullOrWhiteSpace(errorData))
                     exceptionMessage = $"{exceptionMessage} - {errorData}";
 
-                LogTrace("Recieved Error Response {id}: {message} {data}", modified.CommandId, message, errorData);
+                LogTrace("Recieved Error Response {0}: {1} {2}", modified.CommandId, message, errorData);
                 throw new CommandResponseException(exceptionMessage)
                 {
                     Code = modified.Result.Value<long>("code")
@@ -261,7 +261,7 @@ private void ProcessIncomingMessage(string message)
                 }
 
                 commandInfo.Result = messageObject["result"];
-                LogTrace("Recieved Response {id}: {message}", commandId, commandInfo.Result.ToString());
+                LogTrace("Recieved Response {0}: {1}", commandId, commandInfo.Result.ToString());
                 commandInfo.SyncEvent.Set();
                 return;
             }
@@ -272,12 +272,12 @@ private void ProcessIncomingMessage(string message)
                 var methodParts = method.Split(new char[] { '.' }, 2);
                 var eventData = messageObject["params"];
 
-                LogTrace("Recieved Event {method}: {params}", method, eventData.ToString());
+                LogTrace("Recieved Event {0}: {1}", method, eventData.ToString());
                 OnDevToolsEventReceived(new DevToolsEventReceivedEventArgs(methodParts[0], methodParts[1], eventData));
                 return;
             }
 
-            LogTrace("Recieved Other: {message}", message);
+            LogTrace("Recieved Other: {0}", message);
         }
 
         private void OnDevToolsEventReceived(DevToolsEventReceivedEventArgs e)

diff --git a/dotnet/src/webdriver/DriverOptions.cs b/dotnet/src/webdriver/DriverOptions.cs
@@ -394,7 +394,7 @@ protected bool IsKnownCapabilityName(string capabilityName)
         /// <returns>The name of the type-safe option for the given capability name.</returns>
         protected string GetTypeSafeOptionName(string capabilityName)
         {
-            if (this.IsKnownCapabilityName(capabilityName))
+            if (!this.IsKnownCapabilityName(capabilityName))
             {
                 return string.Empty;
             }