java: fix camel case in method name numberOfWindowsToBe

Signed-off-by: Daniel Davison <[email protected]>
SeleniumHQ · Oct 8, 2015 · 55715c9 · 55715c9
1 parent e4917b1
commit 55715c9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/java/client/src/org/openqa/selenium/support/ui/ExpectedConditions.java b/java/client/src/org/openqa/selenium/support/ui/ExpectedConditions.java
@@ -847,7 +847,15 @@ public String toString() {
     };
   }
 
+  /**
+   * @deprecated please use {@link #numberOfWindowsToBe(int)} instead
+   */
+  @Deprecated
   public static ExpectedCondition<Boolean> numberOfwindowsToBe(final int expectedNumberOfWindows) {
+    return numberOfWindowsToBe(expectedNumberOfWindows);
+  }
+
+  public static ExpectedCondition<Boolean> numberOfWindowsToBe(final int expectedNumberOfWindows) {
     return new ExpectedCondition<Boolean>() {
       @Override
       public Boolean apply(WebDriver driver) {

diff --git a/java/client/test/org/openqa/selenium/support/ui/ExpectedConditionsTest.java b/java/client/test/org/openqa/selenium/support/ui/ExpectedConditionsTest.java
@@ -27,14 +27,14 @@
 import static org.mockito.Mockito.when;
 import static org.openqa.selenium.support.ui.ExpectedConditions.elementSelectionStateToBe;
 import static org.openqa.selenium.support.ui.ExpectedConditions.not;
+import static org.openqa.selenium.support.ui.ExpectedConditions.numberOfWindowsToBe;
 import static org.openqa.selenium.support.ui.ExpectedConditions.textToBePresentInElementLocated;
 import static org.openqa.selenium.support.ui.ExpectedConditions.urlContains;
 import static org.openqa.selenium.support.ui.ExpectedConditions.urlMatches;
 import static org.openqa.selenium.support.ui.ExpectedConditions.urlToBe;
 import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOf;
 import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOfAllElements;
 import static org.openqa.selenium.support.ui.ExpectedConditions.visibilityOfAllElementsLocatedBy;
-import static org.openqa.selenium.support.ui.ExpectedConditions.numberOfwindowsToBe;
 
 import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
@@ -451,15 +451,15 @@ public void waitingNumberOfWindowsToBeTwoWhenThereAreTwoWindowsOpen() {
     Set<String> twoWindowHandles = Sets.newHashSet("w1", "w2");
     when(mockDriver.getWindowHandles()).thenReturn(twoWindowHandles);
 
-    assertTrue(wait.until(numberOfwindowsToBe(2)));
+    assertTrue(wait.until(numberOfWindowsToBe(2)));
   }
 
   @Test(expected = TimeoutException.class)
   public void waitingNumberOfWindowsToBeTwoThrowsTimeoutExceptionWhenThereAreThreeWindowsOpen() {
     Set<String> threeWindowHandles = Sets.newHashSet("w1", "w2", "w3");
     when(mockDriver.getWindowHandles()).thenReturn(threeWindowHandles);
 
-    wait.until(numberOfwindowsToBe(2));
+    wait.until(numberOfWindowsToBe(2));
 
     // then TimeoutException is thrown
   }
@@ -468,7 +468,7 @@ public void waitingNumberOfWindowsToBeTwoThrowsTimeoutExceptionWhenThereAreThree
   public void waitingNumberOfWindowsToBeThrowsTimeoutExceptionWhenGetWindowHandlesThrowsWebDriverException() {
     when(mockDriver.getWindowHandles()).thenThrow(WebDriverException.class);
 
-    wait.until(numberOfwindowsToBe(2));
+    wait.until(numberOfWindowsToBe(2));
 
     // then TimeoutException is thrown
   }