You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I think setting retryOnConnectionFailure is going to mask any real issues, and may cause even more problems. This commit was made in an attempt to fix issue #6025, however the stacktrace in that ticket indicates that the problem happens during reading a response. For example, if a POST request (like clicking an element) succeeds server side, but reading the response fails for some reason and the POST is then retried, the element will be clicked twice, or fail to be clicked a second time and return an exception.
550cd0c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think setting retryOnConnectionFailure is going to mask any real issues, and may cause even more problems. This commit was made in an attempt to fix issue #6025, however the stacktrace in that ticket indicates that the problem happens during reading a response. For example, if a POST request (like clicking an element) succeeds server side, but reading the response fails for some reason and the POST is then retried, the element will be clicked twice, or fail to be clicked a second time and return an exception.
https://medium.com/inloopx/okhttp-is-quietly-retrying-requests-is-your-api-ready-19489ef35ace