Skip to content

Commit

Permalink
Run Edge tests for Ruby on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
p0deje committed Nov 26, 2022
1 parent 7024abb commit 50974df
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
31 changes: 31 additions & 0 deletions .github/workflows/ci-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,37 @@ jobs:
env:
DISPLAY: :99

edge-test:
if: ${{ needs.check_workflow.outputs.result == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(toJson(github.event.commits), '[run ruby]') == true }}
needs: check_workflow
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
target: [ 'edge-test', 'remote-edge-test' ]
os: [ 'windows-latest' ]
steps:
- name: Checkout source tree
uses: actions/checkout@v2
- name: Setup Java
uses: actions/setup-java@v1
with:
java-version: 11
- name: Cache Bazel artifacts
uses: ./.github/actions/cache-bazel
with:
workflow: ruby
key: ${{ matrix.target }}
- name: Setup Edge
uses: browser-actions/setup-edge@latest
with:
edge-version: stable
- name: Run Edge tests
uses: ./.github/actions/bazel
with:
command: test --cache_test_results=no --test_output=all //rb:${{ matrix.target }}
attempts: 3

firefox-test:
if: ${{ needs.check_workflow.outputs.result == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(toJson(github.event.commits), '[run ruby]') == true }}
needs: check_workflow
Expand Down
2 changes: 1 addition & 1 deletion rb/spec/integration/selenium/webdriver/manager_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ module WebDriver
it 'should not add secure cookie when http',
except: [{browser: %i[firefox firefox_nightly],
reason: 'https://github.com/mozilla/geckodriver/issues/1840'},
{browser: :chrome,
{browser: %i[chrome edge],
reason: 'https://bugs.chromium.org/p/chromium/issues/detail?id=1177877#c7'}] do
driver.manage.add_cookie name: 'secure',
value: 'http',
Expand Down

0 comments on commit 50974df

Please sign in to comment.