[rb] fix failing tests

SeleniumHQ · May 25, 2022 · 37be1da · 37be1da
1 parent fa5be62
commit 37be1da
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/common/src/web/pointerActionsPage.html b/common/src/web/pointerActionsPage.html
@@ -69,7 +69,6 @@
                 "button: " + event.button + ", " +
                 "pageX: " + event.pageX + ", " +
                 "pageY: " + event.pageY + ", " +
-                "button: " + event.button + ", " +
                 "buttons: " + event.buttons + ", " +
                 "ctrlKey: " + event.ctrlKey + ", " +
                 "altKey: " + event.altKey + ", " +

diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -136,7 +136,7 @@ module WebDriver
           driver.action.release_actions
           expect(event_input.attribute(:value)).to eq('Clicked')
         end
-     end
+      end
 
       describe '#click' do
         it 'clicks provided element' do
@@ -323,6 +323,7 @@ module WebDriver
           delta_y = footer.rect.y
 
           driver.action.scroll_by(0, delta_y).perform
+          sleep 0.2
 
           expect(in_viewport?(footer)).to eq true
         end
@@ -337,6 +338,7 @@ module WebDriver
           driver.action.scroll_from(scroll_origin, 0, 200).perform
 
           driver.switch_to.frame(iframe)
+          sleep 0.2
           checkbox = driver.find_element(name: 'scroll_checkbox')
           expect(in_viewport?(checkbox)).to eq true
         end
@@ -347,6 +349,7 @@ module WebDriver
           scroll_origin = WheelActions::ScrollOrigin.element(footer, 0, -50)
 
           driver.action.scroll_from(scroll_origin, 0, 200).perform
+          sleep 0.2
 
           iframe = driver.find_element(tag_name: 'iframe')
           driver.switch_to.frame(iframe)
@@ -387,7 +390,7 @@ module WebDriver
       end
 
       def properties(element)
-        element.text.sub(/.*?\s/, '').split(',').map { |item| item.lstrip.split /\s*:\s*/ }.to_h
+        element.text.sub(/.*?\s/, '').split(',').to_h { |item| item.lstrip.split(/\s*:\s*/) }
       end
 
       def in_viewport?(element)

diff --git a/rb/spec/integration/selenium/webdriver/element_spec.rb b/rb/spec/integration/selenium/webdriver/element_spec.rb
@@ -57,7 +57,7 @@ module WebDriver
 
         it 'any element in form' do
           driver.navigate.to url_for('formPage.html')
-          driver.find_element(id: 'form > p').submit
+          driver.find_element(css: 'form > p').submit
 
           expect(driver.title).to eq('We Arrive Here')
         end