Skip to content

Commit

Permalink
Sending geckodriver logs to stderr by default. Default log level is l…
Browse files Browse the repository at this point in the history
…ow enough, so the log does not look polluted. Ufortunately, geckodriver does not allow to separate its own log from the browser logs, so messages from the browser log can appear in the log even on the lowest level.
  • Loading branch information
barancev committed Nov 6, 2017
1 parent d5d3cb4 commit 373261b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ protected GeckoDriverService createDriverService(File exe, int port,
// TODO: This stream is leaked.
service.sendOutputTo(new FileOutputStream(getLogFile()));
} else {
service.sendOutputTo(ByteStreams.nullOutputStream());
service.sendOutputTo(System.err);
}
}
return service;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ protected boolean hasShutdownEndpoint() {
return true;
}

/**
* @deprecated Visibility will be restricted to 'protected' soon.
*/
@Deprecated
public void sendOutputTo(OutputStream outputStream) {
this.outputStream = Preconditions.checkNotNull(outputStream);
}
Expand Down

0 comments on commit 373261b

Please sign in to comment.