Allow netty server to close with open connections

SeleniumHQ · Feb 4, 2020 · 35725b2 · 35725b2
1 parent 177754a
commit 35725b2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/java/server/src/org/openqa/selenium/netty/server/NettyServer.java b/java/server/src/org/openqa/selenium/netty/server/NettyServer.java
@@ -107,14 +107,15 @@ public URL getUrl() {
   @Override
   public void stop() {
     try {
+      bossGroup.shutdownGracefully().sync();
+      workerGroup.shutdownGracefully().sync();
+
       channel.closeFuture().sync();
     } catch (InterruptedException e) {
       Thread.currentThread().interrupt();
       throw new UncheckedIOException(new IOException("Shutdown interrupted", e));
     } finally {
       channel = null;
-      bossGroup.shutdownGracefully();
-      workerGroup.shutdownGracefully();
     }
   }