message response may cause json loads ValueError when it's not actual…

…ly json and just a string (like the message that occurs when firefox driver thinks another element will receive the click) Fixes #1478
SeleniumHQ · Jan 14, 2016 · 2641315 · 2641315
1 parent 86c963d
commit 2641315
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/py/selenium/webdriver/remote/errorhandler.py b/py/selenium/webdriver/remote/errorhandler.py
@@ -99,9 +99,12 @@ def check_response(self, response):
             value_json = response.get('value', None)
             if value_json and isinstance(value_json, basestring):
                 import json
-                value = json.loads(value_json)
-                status = value['error']
-                message = value['message']
+                try:
+                  value = json.loads(value_json)
+                  status = value['error']
+                  message = value['message']
+                except ValueError:
+                  pass
 
         exception_class = ErrorInResponseException
         if status in ErrorCode.NO_SUCH_ELEMENT: