[py]: Additional types; remove unused permissions.py

SeleniumHQ · Oct 3, 2022 · 1d2ea04 · 1d2ea04
1 parent 7ead8b8
commit 1d2ea04
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 37 deletions.
diff --git a/py/docs/source/api.rst b/py/docs/source/api.rst
@@ -149,7 +149,6 @@ Webdriver.safari
   :toctree: webdriver_safari
 
   selenium.webdriver.safari.options
-  selenium.webdriver.safari.permissions
   selenium.webdriver.safari.remote_connection
   selenium.webdriver.safari.service
   selenium.webdriver.safari.webdriver

diff --git a/py/docs/source/webdriver_safari/selenium.webdriver.safari.permissions.rst b/py/docs/source/webdriver_safari/selenium.webdriver.safari.permissions.rst
diff --git a/py/selenium/webdriver/remote/remote_connection.py b/py/selenium/webdriver/remote/remote_connection.py
@@ -20,7 +20,6 @@
 import platform
 import socket
 import string
-import typing
 from base64 import b64encode
 from urllib import parse
 
@@ -156,7 +155,7 @@ def _get_connection_manager(self):
 
         return urllib3.PoolManager(**pool_manager_init_args)
 
-    def __init__(self, remote_server_addr, keep_alive=False, ignore_proxy: typing.Optional[bool] = False):
+    def __init__(self, remote_server_addr: str, keep_alive: bool = False, ignore_proxy: bool = False):
         self.keep_alive = keep_alive
         self._url = remote_server_addr
 

diff --git a/py/selenium/webdriver/safari/remote_connection.py b/py/selenium/webdriver/safari/remote_connection.py
@@ -23,7 +23,7 @@ class SafariRemoteConnection(RemoteConnection):
 
     browser_name = DesiredCapabilities.SAFARI["browserName"]
 
-    def __init__(self, remote_server_addr, keep_alive=True, ignore_proxy=False):
+    def __init__(self, remote_server_addr: str, keep_alive: bool = True, ignore_proxy: bool = False):
         super().__init__(remote_server_addr, keep_alive, ignore_proxy=ignore_proxy)
         self._commands["GET_PERMISSIONS"] = ("GET", "/session/$sessionId/apple/permissions")
         self._commands["SET_PERMISSIONS"] = ("POST", "/session/$sessionId/apple/permissions")

diff --git a/py/selenium/webdriver/safari/webdriver.py b/py/selenium/webdriver/safari/webdriver.py
@@ -105,10 +105,7 @@ def __init__(
             )
 
         self._reuse_service = reuse_service
-        if service:
-            self.service = service
-        else:
-            self.service = Service(executable_path, port=port, quiet=quiet, service_args=service_args)
+        self.service = service or Service(executable_path, port=port, quiet=quiet, service_args=service_args)
         if not reuse_service:
             self.service.start()