Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should --disable-component-update be removed? #3329

Closed
tkozybski opened this issue Dec 11, 2024 · 1 comment · Fixed by #3331
Closed

Should --disable-component-update be removed? #3329

tkozybski opened this issue Dec 11, 2024 · 1 comment · Fixed by #3331
Assignees
Labels
enhancement Making things better UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode

Comments

@tkozybski
Copy link

puppeteer/puppeteer#13010

Summarizing the “why” here:

The --disable-component-update command-line flag does two things: it disables component updates (desired) but it also prevents any bundled components from being initialized (undesired).

Since CfT bundles a few components (hyphenation data, MEIPreload, WidevineCdm) the latter effect is problematic.

The above-mentioned CL changes CfT to disable component updates by default (without the need for any command-line flags) while still allowing bundled components to be initialized.

--simulate-outdated-no-au="Tue, 31 Dec 2099 23:59:59 GMT" already disables update checks, and with --disable-component-update https://demo.fingerprint.com/playground detects Chrome as nodriver, even if you didn't run it with Selenium, just this flag alone..

@mdmintz mdmintz self-assigned this Dec 11, 2024
@mdmintz mdmintz added enhancement Making things better UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode labels Dec 11, 2024
@mdmintz
Copy link
Member

mdmintz commented Dec 11, 2024

Good catch. It probably should be removed. I can do that for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making things better UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants