Move away from brace.

[dennisoelkers]

Problem

react-ace is currently using brace as the underlying, browserified version of ace. Unfortunately brace is lagging a magnitude of versions behind and any change (feature, bug fix) to ace needs to propagate through brace before it ends up in react-ace. brace's development is currently stalling, with the last commit being done in February, issues not being answered and even PRs (like thlorenz/brace#139) not being accepted and merged. Therefore I would suggest looking for an alternative which allows to benefit from ace development.

References

Progress on: #

[securingsincity]

@dennisoelkers this would be a pretty big change. I'd be up for some help with this just as i don't know if i have the time to do this all myself

[dennisoelkers]

@securingsincity I have a working branch ready and I am currently working on the remaining tests that fail. The change does not seem to be too big, so I am happy to help. What were your reasons for using brace instead of ace/ace-builds?

[securingsincity]

The interface was cleaner and early on it was easier to work with browserify

[securingsincity]

@dennisoelkers I ended up having to roll back that change. It looks like it breaks importing languages and themes. You can see on the examples that themes and languages no longer work after the switch to ace-builds

[dennisoelkers]

@securingsincity, thanks for the heads up! I actually verified that using the example when submitting the PR and just checked again. It works on my repository, at least as far as I can see. What is the error you are seeing?

[dennisoelkers]

With "example", do you mean yarn run example or the example listed in the README for "basic usage"? The latter requires some changes for sure.

[manubb]

The problem with the demos is probably a problem with github pages build.
(Locally, everything is allright.)
See: #538 (comment)
@securingsincity Could you try to merge again and see if the problem comes back?

[securingsincity]

This was addressed in v8