Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the test helpers opt-in via a test extra #778

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

sdispater
Copy link
Collaborator

Since the testing helpers are only necessary when used in tests, this PR makes them optional via a test extra.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

Copy link

codspeed-hq bot commented Dec 16, 2023

CodSpeed Performance Report

Merging #778 will improve performances by 23.34%

Comparing refactor/make-testing-helpers-extras (0d2c163) with master (482bb80)

Summary

⚡ 1 improvements
✅ 1 untouched benchmarks

Benchmarks breakdown

Benchmark master refactor/make-testing-helpers-extras Change
test_format 2.8 ms 2.3 ms +23.34%

@sdispater sdispater force-pushed the refactor/make-testing-helpers-extras branch from cfc454e to 0d2c163 Compare December 16, 2023 14:46
@@ -18,7 +18,7 @@ classifiers = [
"Programming Language :: Python :: 3.12",
]

dependencies =[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should time-machine be moved to optional-dependencies?

@sdispater sdispater merged commit f6a61db into master Dec 16, 2023
18 checks passed
@sdispater sdispater deleted the refactor/make-testing-helpers-extras branch December 16, 2023 19:58
@sdispater sdispater mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants