fix: handle DST folded dates with start/end_of #713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug
While implementing pendulum usage where I work (switching from buggy
arrow
DST handling), I've found a bug around start_of/end_of handling of dates, when the passed date is exactly in the ambiguous hour period (going out of DST).For example :
Here, the expected behavior would be that I still get the offset from the current hour (as I didn't transition).
The end_of method suffer of the same bug.
Fix proposal
I'm not that familiar with Python and its internal about fold, but reading the PEP, I've found that simply porting the fold field from the original date is enough, as we were missing the information that the date either didn't happen yet, or did.
Pull Request Check List