Rename the Period class to Interval #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secrus
requested changes
Nov 21, 2022
sdispater
force-pushed
the
refactor/rename-period-to-interval
branch
from
96e6ed8 to
832ef14
Compare
Secrus
approved these changes
Nov 21, 2022
Merged
na399
added a commit
to na399/dagster
that referenced
this pull request
Dec 23, 2023
breaking change in pendulum v3 see python-pendulum/pendulum#676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This change is both semantic change and breaking change.
This renames the
Periodclass toIntervalto make its purpose and what it represents clearer.