Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify error message if certifi is not installed #3402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modify error message if certifi is not installed #3402

wants to merge 1 commit into from
+24 −12

Conversation

flying-sheep
Copy link
Member

  • Release notes not necessary because: small fix

@flying-sheep flying-sheep changed the title Add certifi warning Modify error message if certifi is not installed Dec 16, 2024
@flying-sheep flying-sheep requested a review from Intron7 December 16, 2024 10:12
@flying-sheep flying-sheep added this to the 1.10.5 milestone Dec 16, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.53%. Comparing base (391d87a) to head (3bfa929).

Files with missing lines Patch % Lines
src/scanpy/readwrite.py 22.22% 7 Missing ⚠️
src/scanpy/_compat.py 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3402      +/-   ##
==========================================
- Coverage   76.58%   76.53%   -0.05%     
==========================================
  Files         111      111              
  Lines       12872    12881       +9     
==========================================
+ Hits         9858     9859       +1     
- Misses       3014     3022       +8
Files with missing lines Coverage Δ
src/scanpy/_compat.py 79.43% <50.00%> (-2.38%) ⬇️
src/scanpy/readwrite.py 76.82% <22.22%> (-0.93%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Intron7 Intron7 Intron7 approved these changes

Assignees
No one assigned
Labels
Development Process 🚀
Projects
None yet
Milestone
1.10.5
Development

Successfully merging this pull request may close these issues.

certifi not declared as dependency in pyproject.toml
2 participants
@flying-sheep @Intron7