Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] experiment devirgo-style sumcheck + FRI fold #653

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

hero78119
Copy link
Collaborator

@hero78119 hero78119 commented Nov 29, 2024

An experiment to see how much gain we have on e2e latency

Also related to #568

@hero78119 hero78119 marked this pull request as draft November 29, 2024 06:32
@hero78119
Copy link
Collaborator Author

hero78119 commented Dec 5, 2024

Hi @chaosma @yczhangsjtu FYI, please refer changes on file "mpcs/src/basefold/commit_phase.rs", other are just noise and can be ignored.

For benchmarn, before/after this change, e2e remain the same 😂
Few reason

  • I didn't apply complex threading model as prover_v2 in ceno main prove part sumcheck, so in rayon, different thread might take different part of vector, so the cache hit rate is not good
  • basefold openining overhead is small comparing with other part

But the good thing is we can share sumcheck implementation between main proof/mpcs, so we can reduce technical burden and avoid duplicate implementation

Hope this PR can help on WHIR implementation, if you need any input or review on WHIR, I will be happy to learn that and review your implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant