-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scribe-Data pip to usable CLI deployment #149
Comments
After pip, I want to work on conda package as well. |
I'll make an issue for that as well! We need to think about a unified way of deployment though, as we're talking four different directories now. Might be nice if we made an action for that that would use some secrets to do the deployments to each :) |
I think that this issue could potentially be done, @mhmohona, but we'll have to see post deployment if your change of... entry_points={
"console_scripts": [
"scribe-data=scribe_data.cli.main:main",
],
} ... works after the next deployment :) Let's give this a check once we've released and we can then try to pip install and check if the CLI works! Hope so! |
I am going through the official documentation for submitting package for PyPI. For this they suggested to upload our package in Test PyPI first, and then in actual PyPI. Then let me upload it in Test PyPI first, and I will let know how things go. |
Hey @mhmohona 👋 I think that ultimately we should have most of this done right now :) Scribe-Data already is on pip. The only question is whether the user will be able to use it directly after pip installing it :) We didn't yet give you direction on next steps... Issues I'd suggest would be:
|
As far as this issue is concerned, we'll basically just check to see if it works after the next release, and if it does we'll close this, and if not we'll go back to the drawing board 😊 |
Great! Thank you. Another thing is we should implement test for CLI, shouldn't we? |
Sure thing, we can definitely discuss this in the next sync! I'll make the issue to document the CLI :) |
So I just checked for this part -
no, it doesnt work. :( I mean the in a fresh device, after installing scribe-data, |
Hey @mhmohona 👋 We haven't deployed the new changes yet, so it wouldn't work yet :) When you pip install Scribe-Data now you're getting the currently deployed version 3.3, which doesn't have any of the CLI changes. Once we document it a bit, we should be good to do a release and see if this works. Specifically as well, we need to document and do #165 before this one, as what it is that we put in the readme is what's going to be on the PyPI page for Scribe-Data until we release again - i.e. we can't edit the PyPI documentation itself, it can only be done during a release. We can of course do a patch release to fix some things on PyPI though 😊 |
Oh alright. Got it. |
I means it hasn't been deployed to PyPI :) We can even deploy together when the time comes, if you'd like to see how it works, but here are the steps I follow when I deploy Scribe-Data to PyPI:
Let me know if you have further questions! Would be happy to do the deployment in a sync or another call so you can see how it's done, if that would be of interest 😊 |
That would be really great! |
Terms
Description
This issue would investigate and do a deployment of Scribe-Data toPyPI such that when the package is installed it's directly accessible as a CLI. We'll use this issue first to do some research on how best to do this, and once it's done we can implement the decided on changes that need to be made :)
Contribution
@mhmohona will be working on this as a part of GSoC 2024 ☀️ Please write in here so I can assign, and let us know how we can support with research and implementation!
The text was updated successfully, but these errors were encountered: