Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timer.relativeTime is unused #2401

Closed
apple502j opened this issue May 13, 2020 · 3 comments · Fixed by #2416
Closed

Timer.relativeTime is unused #2401

apple502j opened this issue May 13, 2020 · 3 comments · Fixed by #2416

Comments

@apple502j
Copy link
Contributor

Timer.relativeTime is not used anywhere (except for test mocks). Also, this code is the same as Timer.time 😛

We should remove unnecessary code to make files smaller.

@adroitwhiz
Copy link
Contributor

Looks like this was introduced in #410.

@AlexisGoodfellow
Copy link

AlexisGoodfellow commented Sep 4, 2021

Hi! I've been looking over the codebase to get a lay-of-the-land and see if there's any low-hanging fruit I could help with. It looks like this issue is fixed by an open PR (#2416) that is approved to merge and has been for many months.

I took a brief look over the codebase with a good-ol' grep -r to see if there's been any changes or newly introduced usages of the relativeTime function - so far as grep reports, there haven't been any. I merged in the diff from the PR to my local branch to check it out, and all the tests are still passing.

From an outsider's perspective, I don't see anything objectionable about merging this in. I don't have write permissions on this repo though, so I'll leave it up to all of your discretion whether to merge #2146 and close this issue

@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants