Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clones are not properly deleted when deleting sprite #2357

Closed
apple502j opened this issue May 7, 2020 · 2 comments · May be fixed by #2358
Closed

Clones are not properly deleted when deleting sprite #2357

apple502j opened this issue May 7, 2020 · 2 comments · May be fixed by #2358
Labels
help wanted Low Impact Low Severity priority 4
Milestone
Confirm Prioritiz...

Comments

@apple502j
Copy link
Contributor

Expected Behavior

If you delete a sprite, all of their clones would be deleted as well

Actual Behavior

Some clones remain

Steps to Reproduce

  • Make a clone
  • Delete the parent sprite
  • The clone is still on the stage

Operating System and Browser

Windows 10, Firefox 76

Thanks 4096bits for reporting this!
My browser / operating system: Windows NT 10.0, Chrome Edge (the new one) 81.0.4044.129, No Flash version detected
@apple502j apple502j mentioned this issue May 7, 2020
Open
@BryceLTaylor BryceLTaylor added this to the Confirm Prioritization milestone May 11, 2020
@fsih
Copy link
Contributor

fsih commented May 14, 2020

@carljbowman @kathymakes what's the correct behavior here? In 2.0, when you delete a sprite, the clones remain. In 3.0, when you delete a sprite, we delete half of the clones (Can I use Thanos as a verb)

@apple502j
Copy link
Contributor Author

Duplicate of scratchfoundation/scratch-gui#2931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Low Impact Low Severity priority 4
Projects
None yet
Milestone
Confirm Prioritization
Development

Successfully merging a pull request may close this issue.

Fix some clones not getting removed when sprite is deleted apple502j/scratch-vm
4 participants
@ericrosenbaum @BryceLTaylor @fsih @apple502j