Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast sprite names in one place before passing to getSpriteTargetByName #2013

Open
ktbee opened this issue Feb 21, 2019 · 1 comment
Open

Comments

@ktbee
Copy link
Contributor

ktbee commented Feb 21, 2019

Expected Behavior

All blocks should be able to get a sprite target when passing a name if the sprite exists.

Actual Behavior

If the sprite name is a number, it might not be able to find the sprite. getSpriteTargetByName expects a string, and if a block doesn't cast a name to a string, the sprite target can't be found. We should cast the name to a string in one place instead of multiple times in individual blocks.

Steps to Reproduce

See #1743 for repro steps and more details

@ktbee
Copy link
Contributor Author

ktbee commented Feb 21, 2019

@mzgoddard I assigned you this issue since I know this is something you wanted to tackle in your optimization work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants