Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repurpose this repo to host asv benchmark results #3

Open
jeremiedbb opened this issue Sep 3, 2020 · 6 comments
Open

Repurpose this repo to host asv benchmark results #3

jeremiedbb opened this issue Sep 3, 2020 · 6 comments

Comments

@jeremiedbb
Copy link
Member

jeremiedbb commented Sep 3, 2020

@scikit-learn/core-devs are you still ok to repurpose this repo (inactive since 2013) to host results from regular runs of the new asv benchmark suite as discussed in a previous core dev meeting ?

If so, what should be done with it's content ? just delete it (it's still in its forks if ever needed) ?

do you mind if I push directly and not use the PR scheme ? it'll make it faster to iterate quickly to set it up.

Also, it will not be my github account who will be pushing the new results here but https://github.com/sklearn-benchmark-bot. Is it ok if I add it as a collaborator (on this repo only) with push permission ?

@adrinjalali
Copy link
Member

I'm happy to experiment with the repo directly as you suggest, and I wouldn't worry about the old content since it's gonna be in the git history anyway (I assume you're not intending to delete the history :D )

@NicolasHug
Copy link
Member

Thanks for taking care of the benchmarks.

I think it's fine to delete whatever is here and for you to push directly.

Should we rename sciki-learn-speed into scikit-learn-benchmarks? Since we don't benchmark just speed but also memory usage, etc?

Also, it will not be my github account who will be pushing the new results here but @sklearn-benchmark-bot. Is it ok if I add it as a collaborator (on this repo only) with push permission ?

Yes but who's managing @sklearn-benchmark-bot? We should make sure enough core devs have credentials to manage the bot?

Also out of curiosity what's going to happen to https://github.com/scikit-learn-inria-fondation/sklearn-benchmark?

@jeremiedbb
Copy link
Member Author

Also out of curiosity what's going to happen to https://github.com/scikit-learn-inria-fondation/sklearn-benchmark?

It will be deleted. It was just to experiment the automation.

Yes but who's managing @sklearn-benchmark-bot? We should make sure enough core devs have credentials to manage the bot?

Good point. Currently only me, but I can give its credentials to you and the other core devs

Should we rename sciki-learn-speed into scikit-learn-benchmarks

I'm ok with that

@jeremiedbb
Copy link
Member Author

I assume you're not intending to delete the history :D

I'm not :)

@ogrisel
Copy link
Member

ogrisel commented Sep 3, 2020

+1 as well.

@jeremiedbb
Copy link
Member Author

Thanks, let's go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants