From dc425c0ca680ea7e8f3b9d5271c4c7a04bdfabcf Mon Sep 17 00:00:00 2001 From: Scaleway Bot Date: Thu, 17 Oct 2024 09:09:32 +0200 Subject: [PATCH] fix(instance): remove deprecated bootscript documentation (#4187) --- ...est-all-usage-instance-image-create-usage.golden | 1 - ...st-all-usage-instance-server-update-usage.golden | 1 - docs/commands/instance.md | 2 -- internal/namespaces/instance/v1/instance_cli.go | 13 ------------- 4 files changed, 17 deletions(-) diff --git a/cmd/scw/testdata/test-all-usage-instance-image-create-usage.golden b/cmd/scw/testdata/test-all-usage-instance-image-create-usage.golden index 02dbed4aaa..67f49da81d 100644 --- a/cmd/scw/testdata/test-all-usage-instance-image-create-usage.golden +++ b/cmd/scw/testdata/test-all-usage-instance-image-create-usage.golden @@ -25,7 +25,6 @@ ARGS: [zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3) DEPRECATED ARGS: - [default-bootscript] Default bootscript of the image [additional-volumes.{index}.organization-id] Organization ID that own the additional snapshot FLAGS: diff --git a/cmd/scw/testdata/test-all-usage-instance-server-update-usage.golden b/cmd/scw/testdata/test-all-usage-instance-server-update-usage.golden index 1d55aaa3ab..fbf1d40031 100644 --- a/cmd/scw/testdata/test-all-usage-instance-server-update-usage.golden +++ b/cmd/scw/testdata/test-all-usage-instance-server-update-usage.golden @@ -44,7 +44,6 @@ ARGS: [zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | fr-par-3 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2 | pl-waw-3) DEPRECATED ARGS: - [bootscript] [routed-ip-enabled] True to configure the instance so it uses the new routed IP mode (once this is set to True you cannot set it back to False) [enable-ipv6] diff --git a/docs/commands/instance.md b/docs/commands/instance.md index db1048536b..f4571823ab 100644 --- a/docs/commands/instance.md +++ b/docs/commands/instance.md @@ -134,7 +134,6 @@ scw instance image create [arg=value ...] | name | Default: `` | Name of the image | | snapshot-id | Required | UUID of the snapshot that will be used as root volume in the image | | arch | Required
One of: `unknown_arch`, `x86_64`, `arm`, `arm64` | Architecture of the image | -| ~~default-bootscript~~ | Deprecated | Default bootscript of the image | | additional-volumes.{index}.id | | UUID of the snapshot to add | | additional-volumes.{index}.name | | Name of the additional snapshot | | additional-volumes.{index}.size | | Size of the additional snapshot | @@ -2271,7 +2270,6 @@ scw instance server update [arg=value ...] | volumes.{key}.base-snapshot | | ID of the snapshot on which this volume will be based | | volumes.{key}.project | | Project ID of the volume | | volumes.{key}.organization | | Organization ID of the volume | -| ~~bootscript~~ | Deprecated | | | dynamic-ip-required | | | | ~~routed-ip-enabled~~ | Deprecated | True to configure the instance so it uses the new routed IP mode (once this is set to True you cannot set it back to False) | | public-ips.{index} | | A list of reserved IP IDs to attach to the Instance | diff --git a/internal/namespaces/instance/v1/instance_cli.go b/internal/namespaces/instance/v1/instance_cli.go index be3a9085f9..1d530b5ca2 100644 --- a/internal/namespaces/instance/v1/instance_cli.go +++ b/internal/namespaces/instance/v1/instance_cli.go @@ -651,12 +651,6 @@ func instanceServerUpdate() *core.Command { Deprecated: false, Positional: false, }, - { - Name: "bootscript", - Required: false, - Deprecated: true, - Positional: false, - }, { Name: "dynamic-ip-required", Required: false, @@ -1117,13 +1111,6 @@ func instanceImageCreate() *core.Command { Positional: false, EnumValues: []string{"unknown_arch", "x86_64", "arm", "arm64"}, }, - { - Name: "default-bootscript", - Short: `Default bootscript of the image`, - Required: false, - Deprecated: true, - Positional: false, - }, { Name: "extra-volumes.{key}.id", Short: `UUID of the volume`,