Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo two recent reversals #15373

Closed
odersky opened this issue Jun 4, 2022 · 3 comments
Closed

Redo two recent reversals #15373

odersky opened this issue Jun 4, 2022 · 3 comments

Comments

@odersky
Copy link
Contributor

odersky commented Jun 4, 2022

We had to revert #13780 and #14026. These two PRs both fixed soundness bugs but the fixes broke too much code.

We need to address the original bugs re-introducing these PRs after applying some fixes or complements to them.
@odersky odersky added stat:needs triage Every issue needs to have an "area" and "itype" label and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Jun 4, 2022
@odersky odersky added this to the 3.3.0-RC1 milestone Jun 4, 2022
@odersky
Copy link
Contributor Author

odersky commented Jun 12, 2022 •
edited
Loading

See #15423 as a replacement for #13780

@SethTisue SethTisue mentioned this issue Oct 18, 2022
Closed
@SethTisue
Copy link
Member

#15423 is now merged. Should this ticket still be open?

(#15926, the subject of today's Scala 3 Issue Spree, may indicate remaining trouble in this area?)

@dwijnand
Copy link
Member

#15423 is now merged. Should this ticket still be open?

And #15746 addressed #14026, as I see it. So yes, IMO.

@Kordyjan Kordyjan removed this from the 3.3.0-RC1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SethTisue @dwijnand @odersky @Kordyjan