Unexpected eta expansion is behind -Xsource-features:eta-expand-always #10907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires specifying It's not desirable to automatically turn on eta-expand because of innocent case-companion-function. Should there be a migration warning under |
som-snytt
force-pushed
the
issue/13055-eta-x
branch
from
6b0bd77 to
c7aa94c
Compare
|
Do I remember that rebuild request does not restart Travis? |
som-snytt
force-pushed
the
issue/13055-eta-x
branch
from
c7aa94c to
96b5ad2
Compare
|
Rebased for rebuild. |
It's a special case as the migration message would show up in the We could still add it here, no? val mm = if (scala3) ", or in Scala 3 or with -Xsource-features..." else ""
else s"""
|Unapplied methods are only converted to functions when a function type is expected${mm}.
|You can make this conversion explicit by writing `$f _` or `$paf` instead of `$f`.""".stripMargin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require
-Xsource-features:eta-expand-alwaysfor eta-expansion without an expected type.Plain
-Xsource:3is reserved for benign features only.As a consequence,
-Xsource-features:case-companion-functionrequires-Xsource-features:eta-expand-always.Fixes scala/bug#13055