Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine MapOps in concurrent.Map, add MapFactory #10891

Open
wants to merge 1 commit into
base: 2.13.x
Choose a base branch
from
Open

Refine MapOps in concurrent.Map, add MapFactory #10891

wants to merge 1 commit into from

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Oct 18, 2024 •
edited
Loading

The buildFromMapOps implicit has
CC[X, Y] <: Map[X, Y] with MapOps[X, Y, CC, _]

For CC = concurrent.Map the bound is not satisfied, we had MapOps[_, _, mutable.Map, _].

Fixes scala/bug#13047

Need to see about bin compat...

@lrytz
Refine MapOps in concurrent.Map, add MapFactory
7aca0aa 
The `buildFromMapOps` implicit has
`CC[X, Y] <: Map[X, Y] with MapOps[X, Y, CC, _]`

For `CC = concurrent.Map` the bound is not satisfied,
we had `MapOps[_, _, mutable.Map, _]`.
@scala-jenkins scala-jenkins added this to the 2.13.16 milestone Oct 18, 2024
@lrytz
Copy link
Member Author

lrytz commented Oct 18, 2024 •
edited
Loading

MiMa verdict:

scala-library: Failed binary compatibility check against org.scala-lang:scala-library:2.13.15! Found 4 potential problems (filtered 1)

* static method newBuilder()scala.collection.mutable.Builder in interface scala.collection.concurrent.Map does not have a correspondent in other version

* static method from(scala.collection.IterableOnce)java.lang.Object in interface scala.collection.concurrent.Map does not have a correspondent in other version

* in other version, classes mixing scala.collection.concurrent.Map need be recompiled to wire to the new static mixin forwarder method all super calls to method mapFactory()scala.collection.MapFactory

* object scala.collection.concurrent.Map does not have a correspondent in other version

@SethTisue SethTisue added the library:collections PRs involving changes to the standard collection library label Oct 18, 2024
@SethTisue
Copy link
Member

@scala/collections

@SethTisue SethTisue modified the milestones: 2.13.16, 2.13.17 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library:collections PRs involving changes to the standard collection library
Projects
None yet
Milestone
2.13.17
Development

Successfully merging this pull request may close these issues.

No BuildFrom instance for concurrent.Map
3 participants
@lrytz @SethTisue @scala-jenkins