Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make set_version.py compatible with Cargo.lock #213

Closed
JuniorJPDJ opened this issue Nov 21, 2022 · 2 comments
Closed

Make set_version.py compatible with Cargo.lock #213

JuniorJPDJ opened this issue Nov 21, 2022 · 2 comments

Comments

@JuniorJPDJ
Copy link

Hello! I'd like to use this script for packaging this library in Alpine Linux.
I'd like to run maturin with --locked, but setting version to other than locked one makes cargo fail.

Could you please extend regexp a bit so it also catches the name so we can call script twice (for Cargo.toml and Cargo.lock) and make use of --locked?

@messense
Copy link
Collaborator

You can run cargo update -p watchfiles_rust_notify after set_version.py, we do it this way on CI.

- name: set package version
run: python .github/set_version.py
if: "startsWith(github.ref, 'refs/tags/')"
- name: Sync Cargo.lock
run: cargo update -p watchfiles_rust_notify
if: "startsWith(github.ref, 'refs/tags/')"

@samuelcolvin
Copy link
Owner

I've got rid of the set-version thing in preparation for v1, see #309.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants