Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove incorrect rollup types and bump vite #83

Merged
merged 7 commits into from
Feb 25, 2023
Merged

Conversation

DetachHead
Copy link
Contributor

fixes #82

also bump vite to fix another type error, seems to be the same issue as Subwaytime/vite-aliases#36

@samrum
Copy link
Owner

samrum commented Feb 14, 2023

This is missing the associated changes to pnpm-lock.yaml for the Vite version change.

But, if the intention is to fix downstream usages of the plugin, you might want to update the Vite version in https://github.com/samrum/create-vite-plugin-web-extension instead.

If the intention is to fix type issues in the plugin itself, you'd need to commit the updated pnpm-lock-yaml here.

@DetachHead
Copy link
Contributor Author

DetachHead commented Feb 14, 2023

This is missing the associated changes to pnpm-lock.yaml for the Vite version change.

sorry about that, i couldn't because pnpm doesn't work on my work PC. i've updated it now

@DetachHead
Copy link
Contributor Author

no idea why but the errors in the CI are different to the errors i get locally:

ci

 > tsc --noEmit && rollup -c

src/manifestParser/manifestParser.ts:304:15 - error TS2339: Property 'viteMetadata' does not exist on type 'OutputChunk'.

304     chunkInfo.viteMetadata.importedCss.forEach(metadata.css.add, metadata.css);
                  ~~~~~~~~~~~~

src/manifestParser/manifestParser.ts:305:15 - error TS2339: Property 'viteMetadata' does not exist on type 'OutputChunk'.

305     chunkInfo.viteMetadata.importedAssets.forEach(
                  ~~~~~~~~~~~~


Found 2 errors in the same file, starting at: src/manifestParser/manifestParser.ts:304

local

> tsc --noEmit && rollup -c

src/manifestParser/manifestParser.ts:304:5 - error TS18048: 'chunkInfo.viteMetadata' is possibly 'undefined'.

304     chunkInfo.viteMetadata.importedCss.forEach(metadata.css.add, metadata.css);
        ~~~~~~~~~~~~~~~~~~~~~~

src/manifestParser/manifestParser.ts:305:5 - error TS18048: 'chunkInfo.viteMetadata' is possibly 'undefined'.

305     chunkInfo.viteMetadata.importedAssets.forEach(
        ~~~~~~~~~~~~~~~~~~~~~~


Found 2 errors in the same file, starting at: src/manifestParser/manifestParser.ts:304

i fixed it in f57d891 but i think something else is going on because tsc in the ci can't seem to find node_modules/vite/types/metadata.d.ts at all

@DetachHead
Copy link
Contributor Author

i think it was an issue with the lockfile should be fixed now

@samrum samrum merged commit 9043206 into samrum:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rollup types conflict with vite types
2 participants