-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove incorrect rollup types and bump vite #83
Conversation
This is missing the associated changes to pnpm-lock.yaml for the Vite version change. But, if the intention is to fix downstream usages of the plugin, you might want to update the Vite version in https://github.com/samrum/create-vite-plugin-web-extension instead. If the intention is to fix type issues in the plugin itself, you'd need to commit the updated pnpm-lock-yaml here. |
sorry about that, i couldn't because pnpm doesn't work on my work PC. i've updated it now |
no idea why but the errors in the CI are different to the errors i get locally: ci
local
i fixed it in f57d891 but i think something else is going on because |
i think it was an issue with the lockfile should be fixed now |
fixes #82
also bump vite to fix another type error, seems to be the same issue as Subwaytime/vite-aliases#36