Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevBuilder’s output path should respect the root property of ViteConfig #81

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Conversation

haruleekim
Copy link
Contributor

I noticed some issues while using this plugin.

  1. DevBuilder's ourDir is not consistent.

    Looking at the code written, I think you intended to refer to the same location as outDir in ViteConfig.
    But it doesn't work if $(cwd) is not the same as the root of ViteConfig.
    So I modified outDir's path resolution logic to refer to the root of ViteConfig.

  2. DevBuilder always tries to copy the $(cwd)/public directory.

    This path must also be determined by referring to the root of ViteConfig, not $(cwd).
    And the publicDir property of ViteConfig, not const literal "public".
    So I modified them to do so.

Thank you so much for creating this good plugin.

@samrum samrum merged commit 9307b79 into samrum:main Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants