DevBuilder’s output path should respect the root
property of ViteConfig
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some issues while using this plugin.
DevBuilder's
ourDir
is not consistent.Looking at the code written, I think you intended to refer to the same location as
outDir
in ViteConfig.But it doesn't work if
$(cwd)
is not the same as theroot
of ViteConfig.So I modified outDir's path resolution logic to refer to the
root
of ViteConfig.DevBuilder always tries to copy the
$(cwd)/public
directory.This path must also be determined by referring to the
root
of ViteConfig, not$(cwd)
.And the
publicDir
property of ViteConfig, not const literal"public"
.So I modified them to do so.
Thank you so much for creating this good plugin.