Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the options object to all functions #5

Open
djensen47 opened this issue May 15, 2014 · 2 comments
Open

Pass the options object to all functions #5

djensen47 opened this issue May 15, 2014 · 2 comments
Labels
enhancement

Comments

@djensen47
Copy link
Contributor

Right now options is only available for the details and query functions. The filter function, however, seems to be applied to all of the functions except insert.

For consistency, it seems that options should be available on update and delete as well.

If you agree, I can submit a pull request. Just didn't want to do the work if there was a good reason not too.
@ismarslomic
Copy link
Collaborator

@saintedlama this seems reasonable improvement. I support it. @djensen47, are you still positive to submit a pull request for this?

@djensen47
Copy link
Contributor Author

It's been a while since I've looked at this code. It might take me a while before I have some time to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djensen47 @ismarslomic