Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.4.1: Fix main js and type files #613

Merged
merged 1 commit into from
Jul 17, 2023
Merged

1.4.1: Fix main js and type files #613

merged 1 commit into from
Jul 17, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jul 17, 2023

This PR:

  • Due to the changes to the typescript configuration to add correct types, it resulted in a different dist build folder structure which wasn't reflected in the package.json.

@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5574970870

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.2%
Totals Coverage Status
Change from base Build 5574938886: 0.0%
Covered Lines: 315
Relevant Lines: 330
💛 - Coveralls

@mmv08 mmv08 requested review from a team, rmeissner, Uxio0 and akshay-ap and removed request for a team July 17, 2023 11:27
@mmv08 mmv08 merged commit 192c7dc into release-branch/v1.4.1 Jul 17, 2023
@mmv08 mmv08 deleted the v1.4.1/js-bundle-fix branch July 17, 2023 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmeissner rmeissner rmeissner approved these changes

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 was automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap was automatically assigned from safe-global/safe-protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmv08 @rmeissner