Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol fees in the withdraw function #1034

Closed
4 tasks
PaulRBerg opened this issue Sep 4, 2024 · 1 comment
Closed
4 tasks

Add protocol fees in the withdraw function #1034

PaulRBerg opened this issue Sep 4, 2024 · 1 comment
Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Sep 4, 2024 •
edited by andreivladbrg
Loading

Rationale

Make it possible to charge protocol fees at withdrawal time. See https://github.com/sablier-labs/company-discussions/discussions/72.

There are two big advantages for charging fees at withdrawal time compared to deposit:

  • Incentivizes us to pursue more integrations for Lockup
  • Solves the nasty issues associated with airstreams campaign

Spec

Note: this is similar to the historical functionality that used to be available in v1.1.0 and below, however, for simplicity purposes, this newer spec does not include a Comptroller.

  • Add getProtocolFee getter
  • Add _protocolFees mapping
  • Add setProtocolFee setter gated by admin function
  • When the protocol fee is not zero, charge a fee from the withdrawn amount
@PaulRBerg PaulRBerg added type: feature New feature or request. effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Sep 4, 2024
@PaulRBerg PaulRBerg mentioned this issue Sep 4, 2024
Closed
2 tasks
@andreivladbrg andreivladbrg self-assigned this Sep 4, 2024
@andreivladbrg andreivladbrg removed their assignment Oct 31, 2024
@PaulRBerg
Copy link
Member Author

Discarding feature this as per the discussion here.

@PaulRBerg PaulRBerg closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@PaulRBerg PaulRBerg mentioned this issue Nov 6, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulRBerg @andreivladbrg