Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce VOID status and disallow restart after void #218

Closed
3 tasks done
andreivladbrg opened this issue Aug 29, 2024 · 0 comments · Fixed by #221
Closed
3 tasks done

Introduce VOID status and disallow restart after void #218

andreivladbrg opened this issue Aug 29, 2024 · 0 comments · Fixed by #221
Assignees
@andreivladbrg
Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented Aug 29, 2024 •
edited by smol-ninja
Loading

As discussed here: #216

We should:

  • Add isVoided bool in the stream struct which is toggled in void function
  • Check the bool in restart function
  • Introduce VOIDED variant in the Stream enum
@andreivladbrg andreivladbrg self-assigned this Aug 29, 2024
@andreivladbrg andreivladbrg added priority: 1 This is important. It should be dealt with shortly. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect. effort: medium Default level of effort. type: feature New feature or request. labels Aug 29, 2024
@andreivladbrg andreivladbrg mentioned this issue Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: medium Default level of effort. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: VOID status sablier-labs/flow
1 participant
@andreivladbrg