Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think of a way to merge the core and periphery dirs #10

Closed
andreivladbrg opened this issue Aug 7, 2024 · 9 comments · Fixed by #12
Closed

Think of a way to merge the core and periphery dirs #10

andreivladbrg opened this issue Aug 7, 2024 · 9 comments · Fixed by #12
Assignees

Comments

@andreivladbrg
Copy link
Member

Ref sablier-labs/v2-core#979

@andreivladbrg andreivladbrg changed the title Think of a way how to merge the core and periphery dirs Think of a way to merge the core and periphery dirs Aug 7, 2024
@andreivladbrg
Copy link
Member Author

Idea:

└── deployments
    ├── lockup
    │  ├── v1.0.0 // both core and periphery
    │  └── v1.1.0 // both core and periphery 
    └── flow
       ├── v1.0.0 
       └── v1.1.0 

@smol-ninja
Copy link
Member

Looks good to me.

@PaulRBerg
Copy link
Member

Wouldn't it be better to rename periphery to airdrops, and add a warning in <v1.2.0 that the npm package hsed to be called @sablier/v2-periphery?

@andreivladbrg
Copy link
Member Author

this issue was created in august, at that time there was no discussion about airdrop repo (will update the OP)

@PaulRBerg
Copy link
Member

OK, so you agree with my proposal?

@andreivladbrg
Copy link
Member Author

Wouldn't it be better to rename periphery to airdrops, and add a warning in <v1.2.0 that the npm package hsed to be called @sablier/v2-periphery?

@PaulRBerg just realized that this wouldn’t work, as the periphery used to contain the proxy contract in the earlier versions. so, IMO naming it “airdrops” would be misleading. wdyt?

we will have airdrops only for the new versions, and we can mention “previously known as periphery.”

@smol-ninja
Copy link
Member

How about moving previously deployed merkle campaign contracts to airdrops and keep rest (batch, proxy) etc in core?

@andreivladbrg
Copy link
Member Author

andreivladbrg commented Dec 2, 2024

How about moving previously deployed merkle campaign contracts to airdrops and keep rest (batch, proxy) etc in core?

even more confusing IMO :))

image

@PaulRBerg
Copy link
Member

good point @andreivladbrg

we will have airdrops only for the new versions, and we can mention “previously known as periphery.”

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants