Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Issues #18

Open
BenLiyanage opened this issue Jan 5, 2018 · 0 comments
Open

Memory Issues #18

BenLiyanage opened this issue Jan 5, 2018 · 0 comments

Comments

@BenLiyanage
Copy link

Hey,

This repo looks pretty dead to me but I figured I'd drop a comment and offer to help in the event that someone is still listening.

It looks like slither is reading the whole files into memory, which does not scale. I'm proposing replacing storing all the data in a hash here with a yield so that the lines are parsed on demand. There may need to be a little fiddling with the sections to make this work correctly, but it seems pretty doable to me.

Let me know what you think.
-Ben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant