Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ability to make non-activating window on macOS #4035

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Implement ability to make non-activating window on macOS #4035

merged 4 commits into from
Dec 12, 2024

Conversation

Exidex
Copy link
Contributor

@Exidex Exidex commented Dec 8, 2024 •
edited by madsmtm
Loading

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

Fixes #3894. I don't really have any experience with macOS-related programming, so not really sure if it is technically correct but it does seem to work properly

@Exidex Exidex requested a review from madsmtm as a code owner December 8, 2024 21:51
@Exidex Exidex force-pushed the ns-panel branch 2 times, most recently from e301605 to 2dd376c Compare December 8, 2024 22:03
@madsmtm madsmtm added S - enhancement Wouldn't this be the coolest? DS - macos labels Dec 8, 2024
@Exidex Exidex force-pushed the ns-panel branch 2 times, most recently from d6ad01c to eb93eac Compare December 8, 2024 22:10
madsmtm
madsmtm requested changes Dec 8, 2024
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine

src/platform/macos.rs Outdated Show resolved Hide resolved
src/platform_impl/apple/appkit/view.rs Outdated Show resolved Hide resolved
src/platform_impl/apple/appkit/window.rs Outdated Show resolved Hide resolved
src/platform_impl/apple/appkit/window.rs Outdated Show resolved Hide resolved
@Exidex Exidex requested a review from madsmtm December 12, 2024 23:16
madsmtm
madsmtm approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few nits, I'll fix them myself through GitHub's UI ('cause I'm too lazy to check out your branch locally ;) )

src/platform/macos.rs Outdated Show resolved Hide resolved
src/changelog/unreleased.md Outdated Show resolved Hide resolved
madsmtm
madsmtm reviewed Dec 12, 2024
View reviewed changes
src/platform/macos.rs Outdated Show resolved Hide resolved
@madsmtm madsmtm merged commit 4d5e68c into rust-windowing:master Dec 12, 2024
58 checks passed
@madsmtm madsmtm added this to the Version 0.31.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
DS - macos S - enhancement Wouldn't this be the coolest?
Milestone
Version 0.31.0
Development

Successfully merging this pull request may close these issues.

MacOS: non-activating window
2 participants
@Exidex @madsmtm