Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBSD build started to fail #498

Closed
kpcyrd opened this issue May 6, 2018 · 4 comments
Closed

OpenBSD build started to fail #498

kpcyrd opened this issue May 6, 2018 · 4 comments
Labels
C - waiting on author Waiting for a response or another PR DS - wayland DS - x11

Comments

@kpcyrd
Copy link

kpcyrd commented May 6, 2018

hey!

I just wanted to let you know that the openbsd build started failing yesterday: https://openbsd.rs/#/builders/22/builds/6

It seems nix was pulled in as a dependency in 1e97103 while the latest version doesn't build on 6.3 yet: nix-rust/nix#893. This issue is already fixed on master, but needs a dependency bump after it has been released.

@francesca64
Copy link
Member

Thanks for the heads up, and for fixing the underlying problem!

It looks like we should wait for the next nix version before making a release. Do you agree, @vberger? (Since you're the one who has to bubble this up...)

@francesca64 francesca64 added DS - x11 DS - wayland C - waiting on author Waiting for a response or another PR labels May 6, 2018
@elinorbgr
Copy link
Contributor

Ah, the nix dependency should not be there, and is an unfortunate consequence of how cargo features do not interact very well with optional dependencies... (wayland-protocols pulls wayland-server while it should not actually).

I'll see if I can fix that in wayland-rs.

@elinorbgr
Copy link
Contributor

Okay, I've released version 0.20.3 of wayland-client/wayland-protocols, which gets rid of the nix dependency. A simple cargo update should fix it (unless we want to explicitly bump the dep in winit's Cargo.toml ?).

@kpcyrd
Copy link
Author

kpcyrd commented May 7, 2018

The build is green again! :) https://openbsd.rs/#/builders/22/builds/7

@kpcyrd kpcyrd closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on author Waiting for a response or another PR DS - wayland DS - x11
Development

No branches or pull requests

3 participants