Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rustc's way to get the system root #48

Closed
xFrednet opened this issue Nov 5, 2022 · 0 comments · Fixed by #325
Closed

Use rustc's way to get the system root #48

xFrednet opened this issue Nov 5, 2022 · 0 comments · Fixed by #325
Labels
C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver E-good-first-issue Participation: Good for newcomers

Comments

@xFrednet
Copy link
Member

xFrednet commented Nov 5, 2022

The driver like Clippy used to have a complicated way to find the system root for the compiler files. rust-lang/rust#103660 added a new uniform way that should also be used by this rustc driver.

See: https://github.com/rust-linting/rust-linting/blob/ce1eb57dbdcf72f1b7ec820725ccf64bc2d90336/linter_driver_rustc/src/main.rs#L203
@xFrednet xFrednet added C-enhancement Category: New feature or request E-good-first-issue Participation: Good for newcomers D-rustc-driver Driver: Rustc Driver labels Nov 5, 2022
This was referenced Nov 30, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver E-good-first-issue Participation: Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rustc: Simplify --sysroot code after rust#103660 xFrednet/marker
1 participant
@xFrednet