diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e2665fee..3db3f317 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -234,4 +234,20 @@ jobs: # There may be bugs in the release build of our binaries. For example, in the past # we saw that LTO could lead to exit code: 0xc0000005, STATUS_ACCESS_VIOLATION crash - - run: cargo marker -l 'marker_lints="*"' + # FIXME: The stable version of Marker tested by this command might use a different toolchain + # version then the one used for the development of rustc driver. Running Marker only loads the + # library files for the toolchain it's executed with and "ignores" the toolchain defined in + # `rust-toolchain.toml`. Therefore, it's not possible to run the stable version of marker + # on `marker_rustc_driver`. + # In the future it would be better to run this smoke test on bigger libraries like tokio, serde + # bevy etc. For that, it would be good to extract the lintcheck tool from Clippy into a standalone + # tool. + - run: >- + cargo +stable marker + -l 'marker_lints="*"' + -- + --workspace + --exclude marker_rustc_driver + --exclude marker_lints + --exclude marker_uitest + diff --git a/scripts/release/install.ps1 b/scripts/release/install.ps1 index cb9f88fc..510a5f25 100755 --- a/scripts/release/install.ps1 +++ b/scripts/release/install.ps1 @@ -71,9 +71,9 @@ Using config env vars (override these if needed): $version = "0.5.0" # endregion replace marker version unstable -# region replace rust toolchain release +# region replace rust toolchain unstable $toolchain = "nightly-2023-11-16" -# endregion replace rust toolchain release +# endregion replace rust toolchain unstable # Log the command, execute, and fail if its exit code is non-zero. # Surprisingly PowerShell can't do the exit code checks for us out of the box. diff --git a/scripts/release/install.sh b/scripts/release/install.sh index 9667abe5..67f83b58 100755 --- a/scripts/release/install.sh +++ b/scripts/release/install.sh @@ -27,9 +27,9 @@ echo "Bash version: $BASH_VERSION" >&2 version=0.5.0 # endregion replace marker version unstable -# region replace rust toolchain release +# region replace rust toolchain unstable toolchain=nightly-2023-11-16 -# endregion replace rust toolchain release +# endregion replace rust toolchain unstable function step { local cmd="$1" diff --git a/scripts/release/set-version.diff b/scripts/release/set-version.diff index 4025b2b8..65401216 100644 --- a/scripts/release/set-version.diff +++ b/scripts/release/set-version.diff @@ -211,17 +211,9 @@ -$version = "X.Y.Z" +$version = "0.1.0" # endregion replace marker version unstable - # region replace rust toolchain release --$toolchain = "nightly-YYYY-MM-DD" -+$toolchain = "nightly-2023-01-01" - # endregion replace rust toolchain release === scripts/release/install.sh === # region replace marker version unstable -version=X.Y.Z +version=0.1.0 # endregion replace marker version unstable - # region replace rust toolchain release --toolchain=nightly-YYYY-MM-DD -+toolchain=nightly-2023-01-01 - # endregion replace rust toolchain release