Rollup of 9 pull requests #47151
Merged
Rollup of 9 pull requests #47151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kennytm
commented
Jan 3, 2018
kennytm
commented
- Successful merges: Delay panic from incoherent drop implementation #47104, Fix typo #47107, Minor cleanup for slice::Chunks and ChunksMut #47113, [unstable book] remove duplicate entries #47117, memchr: fix variable name in docstrings #47118, Fix panic condition docs for Vec::insert. #47121, Mention SliceConcatExt's stability in its docs #47125, Defocus search bar in rustdoc pages #47134, Document when LineWriter flushes; document errors for into_inner. #47145
- Failed merges:
Previously Chunks used size and ChunksMut used chunk_size
SliceConcatExt's status as an unstable trait with stable methods is documented in the compiler error for using it, and in https://doc.rust-lang.org/std/prelude/, but it is not mentioned in the trait itself. Mentioning the methods can be used in stable rust today should help users who are looking for a `join` method while working on stable rust.
Escape now removes focus from the search bar
Fixed intentaion (tabs -> spaces) Added trailing newline
…-drop, r=estebank Delay panic from incoherent drop implementation Closes rust-lang#41974
Fix typo I am assuming that there was once something else you could do and somebody forgot to remove "either". Is that correct?
Minor cleanup for slice::Chunks and ChunksMut This only renames the `size` field to `chunk_size` in one of them for consistency, and changes an assertion to check for != 0 instead of > 0.
[unstable book] remove duplicate entries if a unstable feature is a language feature, it shouldn't also have a library feature stub generated
memchr: fix variable name in docstrings upstream BurntSushi/memchr#24 r=BurntSushi
Fix panic condition docs for Vec::insert. Fixes rust-lang#47065.
Mention SliceConcatExt's stability in its docs Just saw someone in IRC mention there being no stable way to join string slices! It isn't entirely clear from the rust documentation that `SliceConcatExt` is usable. While this is mentioned in https://doc.rust-lang.org/std/prelude/, the trait has nothing to indicate that it's currently usable if found via a documentation search. The wording on this could probably be improved, but I'm hoping its better than nothing.
Defocus search bar in rustdoc pages rust-lang/rfcs#2265
… r=QuietMisdreavus Document when LineWriter flushes; document errors for into_inner. Fixes rust-lang#42468.
|
Some changes occurred in HTML/CSS. |
|
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=9 |
|
📌 Commit b416119 has been approved by |
kennytm
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 3, 2018
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.