Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fully de-stabilize all custom inner attributes #134276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fully de-stabilize all custom inner attributes #134276

wants to merge 1 commit into from
+40 −97

Conversation

RalfJung
Copy link
Member

#![test] and #![rustfmt::skip] were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (#82399) and shown in future-compat reports since Rust 1.77 (#116274).

Cc @rust-lang/lang @petrochenkov

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2024

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2024
@RalfJung RalfJung force-pushed the destabilize-custom-inner-attr branch from ca4ddc2 to cb2a31c Compare December 13, 2024 17:50
@RalfJung RalfJung added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label Dec 13, 2024
@RalfJung
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
@bors
Auto merge of rust-lang#134276 - RalfJung:destabilize-custom-inner-at…
da0275e 
…tr, r=<try>

fully de-stabilize all custom inner attributes

`#![test]` and `#![rustfmt::skip]` were accidentally accepted in more places than they should. These have been marked as soft-unstable since forever (rust-lang#82399) and shown in future-compat reports since Rust 1.77 (rust-lang#116274).

Cc `@rust-lang/lang` `@petrochenkov`
@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit cb2a31c with merge da0275e101cdc809ce291ed8b64d6f82c6b65467...

@bors
Copy link
Contributor

bors commented Dec 13, 2024

☀️ Try build successful - checks-actions
Build commit: da0275e (da0275e101cdc809ce291ed8b64d6f82c6b65467)

@RalfJung
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-134276 created and queued.
🤖 Automatically detected try build da0275e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2024
@RalfJung RalfJung added I-lang-nominated Nominated for discussion during a lang team meeting. and removed I-lang-nominated Nominated for discussion during a lang team meeting. labels Dec 14, 2024
@RalfJung RalfJung mentioned this pull request Dec 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SparrowLii SparrowLii

Labels
S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @bors @craterbot @SparrowLii