Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc doesn't show explicit elided lifetimes in function signatures #75225

Closed
Nemo157 opened this issue Aug 6, 2020 · 1 comment · Fixed by #75237
Closed

rustdoc doesn't show explicit elided lifetimes in function signatures #75225

Nemo157 opened this issue Aug 6, 2020 · 1 comment · Fixed by #75237
Assignees
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Nemo157
Copy link
Member

Nemo157 commented Aug 6, 2020

I tried this code:

pub fn split(&mut self) -> (ReadHalf<'_>, WriteHalf<'_>) { ... }

I expected to see this happen: the documentation to show the explicit elided lifetime

Instead, this happened: the lifetime disappeared (https://docs.rs/tokio/0.2.22/tokio/net/struct.TcpStream.html#method.split)

If anything, to go with Rust 2018 idioms it seems like rustdoc should be adding this explicit elided lifetime if it was left implicit.

Meta

rustc 1.47.0-nightly (8ad7bc3f4 2020-07-21)
docsrs 0.6.0 (c9e59af 2020-07-19)
@Nemo157 Nemo157 added the C-bug Category: This is a bug. label Aug 6, 2020
@jonas-schievink jonas-schievink added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 6, 2020
@nbdd0121
Copy link
Contributor

nbdd0121 commented Aug 6, 2020

@rustbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants