Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic dark theme doesn't work #63830

Closed
fenhl opened this issue Aug 23, 2019 · 0 comments · Fixed by #63847
Closed

Automatic dark theme doesn't work #63830

fenhl opened this issue Aug 23, 2019 · 0 comments · Fixed by #63847
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@fenhl
Copy link
Contributor

fenhl commented Aug 23, 2019

Requested in #61079 and implemented in #61236, the automatic theme switching doesn't seem to do anything: If I visit https://doc.rust-lang.org/nightly/std/ while the system is in dark mode, I can see in the developer tools that the <html> element has the style content: "dark";, but the page is still showing as the light theme. Local storage is empty for doc.rust-lang.org, and the issue affects private windows as well.

Tested on:

  • Firefox 68.0.2 on macOS 10.14.6
  • Firefox 68.0.2 on Windows 10
  • Chrome 76.0.3809.100 on Windows 10

cc @GuillaumeGomez
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 23, 2019
@GuillaumeGomez GuillaumeGomez self-assigned this Aug 23, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Aug 24, 2019
Merged
@bors bors closed this as completed in 5f07ff7 Aug 31, 2019
@fenhl fenhl mentioned this issue Sep 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rustdoc] Fix system theme detection GuillaumeGomez/rust
3 participants
@fenhl @jonas-schievink @GuillaumeGomez