Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#61027 #61031

Closed
rust-highfive opened this issue May 22, 2019 · 3 comments
Closed

rls no longer builds after rust-lang/rust#61027 #61031

rust-highfive opened this issue May 22, 2019 · 3 comments
Assignees
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #61027, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 22, 2019
@pnkfelix
Copy link
Member

pnkfelix commented May 23, 2019

in the absence of a log describing the problem, I'm currently guessing that this is possibly due to #59742. (100% guess.)

My understanding is that this sort of breakage is not a "drop everything" kind of problem, but something we do want to resolve in due course.

triage: P-medium; removing nomination. Assigning to self to try to keep track of it. But I suspect @Xanewok will be best suited to do the actual work.

@pnkfelix pnkfelix added P-high High priority and removed I-nominated labels May 23, 2019
@pnkfelix pnkfelix self-assigned this May 23, 2019
@pnkfelix pnkfelix added P-medium Medium priority and removed P-high High priority labels May 23, 2019
@pnkfelix
Copy link
Member

(its also possible that this was fixed but no one linked this issue from the PR that fixed it...)

@Xanewok
Copy link
Member

Xanewok commented May 23, 2019

Clippy-related breakage, I believe this was specific instance was fixed in #61044.

@Xanewok Xanewok closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants