Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: profile = "tools" contains incompatible options. #127951

Closed
aDotInTheVoid opened this issue Jul 19, 2024 · 2 comments
Closed

bootstrap: profile = "tools" contains incompatible options. #127951

aDotInTheVoid opened this issue Jul 19, 2024 · 2 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-download-rustc Area: The `rust.download-rustc` build option. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@aDotInTheVoid
Copy link
Member

With a config.toml of just:

profile = "tools"

rustdoc fails to build:

$ ./x build ./src/librustdoc/
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
thread 'main' panicked at src/core/config/config.rs:2705:5:
ERROR: Setting `rust.debug-logging` is incompatible with `rust.download-rustc`.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Build completed unsuccessfully in 0:00:00

config.tools.toml should be changed such that including it works.

Alternatively, bootstrap could be taught to build tools with debugging enabled, even if the compiler/ crates don't have debug logging.

Probably due to #127322, CC @onur-ozkan
@aDotInTheVoid aDotInTheVoid added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-download-rustc Area: The `rust.download-rustc` build option. labels Jul 19, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 19, 2024
@aDotInTheVoid aDotInTheVoid removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 19, 2024
@onur-ozkan
Copy link
Member

There is #127913 for fixing it.

@onur-ozkan
Copy link
Member

There is #127913 for fixing it.

PR is merged, closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-download-rustc Area: The `rust.download-rustc` build option. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aDotInTheVoid @onur-ozkan @rustbot