Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: rustdoc is off-by-1-stage #123235

Open
RalfJung opened this issue Mar 30, 2024 · 1 comment
Open

bootstrap: rustdoc is off-by-1-stage #123235

RalfJung opened this issue Mar 30, 2024 · 1 comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@RalfJung
Copy link
Member

The Step that builds rustdoc decrements the stage by 1 before building. That's very confusing, it means ./x.py build rustdoc --stage 0 is a NOP even though usually stage 0 is the stage you want to build!

I think instead Builder::rustdoc should do this decrementing. Or maybe there should be an AssembleRustdoc step that matches the current Assemble step and does the same stage decrementing there.

The current situation is also inconsistent between rustdoc and other similar tools like clippy or Miri; only rustdoc does the stage decrementing in its build Step.

@RalfJung RalfJung added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 30, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 30, 2024
@onur-ozkan
Copy link
Member

#119946 :(

@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 30, 2024
@jieyouxu jieyouxu added the C-bug Category: This is a bug. label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants