-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic when compiling redis-rs with clippy #1517
Comments
Not sure what to do about that. How else can we get the version? |
I'm inclined to say "Just don't do it then", but that would be not so nice. |
Alternatively you can build clippy as a library and use RUSTFLAGS to enable clippy. Unfortunately I see no way to get |
Same error with rocket_codegen @SergioBenitez |
I wonder if clippy could not ship a RUSTC wrapper that makes it behave more the same. Parsing RUSTC output is not unpopular. |
@Eijebong Rocket should be emitting a warning if it can't retrieve the current version; the build script should not panic in this case. |
Ok, I got no warning whatsoever... I guess it was redis again but it panicked under the « compile rocket_codegen » line... Sorry :p |
@Eijebong That's caused by rust-lang/cargo#3777. If you pass |
This was causing troubles with `cargo clippy` as they seem to replace the RUSTC env variable (see https://github.com/Manishearth/rust-clippy/issues/1517)
redis-rs uses the "RUSTC" environment variable to determine the current rustc version by calling
$RUSTC --version
.Since clippy sets this to "/home/user/.cargo/bin/cargo-clippy", the version is not the expected format at all and it just panics because there is no error handling in the build.rs
@mitsuhiko @badboy
The text was updated successfully, but these errors were encountered: