You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest changing the message of such a commit from
Auto merge of #7140
to
Auto merge of rust-lang/rust-clippy#7140
This way, linking works correctly. And it still doesn’t need a full URL. I double-checked that the linking works correctly here: steffahn/rust@b41e6a2.
I’m not sure how homu works, if this is something that needs to be changed here or just some configuration.
Also note that this is only strictly necessary for subtrees such as clippy or rustfmt, but I guess it wouldn’t hurt either if the prefixes were added in all repositories.
The text was updated successfully, but these errors were encountered:
There’s another issue with issues mentioned in PR descriptions. These get turned into commit messages for the auto-merge / rollup-merge commits. See #145 (comment).
Looking at clippy commits in the rust repo, e.g. in PR rust-lang/rust#84980, you’ll see commit messages from @bors merge commits, e.g.
rust-lang/rust@ce37099
containing PR numbers from rust-lang/rust-clippy. But it’s just the number in a commit message, so github inserts a link to the same number in rust-lang/rust! So it links to the issue rust-lang/rust#7140 instead of the PR rust-lang/rust-clippy#7140. Look at that issue, github even inserted a back-link to the entirely unrelated bors commit.
I suggest changing the message of such a commit from
to
This way, linking works correctly. And it still doesn’t need a full URL. I double-checked that the linking works correctly here: steffahn/rust@b41e6a2.
I’m not sure how homu works, if this is something that needs to be changed here or just some configuration.
Also note that this is only strictly necessary for subtrees such as clippy or rustfmt, but I guess it wouldn’t hurt either if the prefixes were added in all repositories.
The text was updated successfully, but these errors were encountered: